-
-
Notifications
You must be signed in to change notification settings - Fork 989
Update guidelines on using GenAI #1778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
726ec3c
e71105b
f8ab6ab
a04cd52
ef31ff8
ff94cd6
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
…delines. Add the Guidelines to the contributing table.
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -1,8 +1,8 @@ | ||||||||||||||
| .. _generative-ai: | ||||||||||||||
|
|
||||||||||||||
| ============= | ||||||||||||||
| Generative AI | ||||||||||||||
| ============= | ||||||||||||||
| ================================= | ||||||||||||||
| Guidelines in using Generative AI | ||||||||||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
| ================================= | ||||||||||||||
|
Comment on lines
+3
to
+5
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
|
|
||||||||||||||
| Generative AI tools are evolving rapidly, and their work can be helpful. As with using any tool, the resulting | ||||||||||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It wasn't done before in this file for some reason, but could we please wrap lines?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I was going to say the opposite :) The rewrap make it hard to review what has changed. Please can we keep a minimal diff for now, and only rewrap just before merge?
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Just before merge sounds good to me :-)
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think we should personify the tools any longer. I also want to be more objective about the results.
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Perhaps just simplify to: "AI tools can produce results quickly. As with using any ..." FWIW, "their work" was not intended as personification, it a extremely common phrase for how we refer to any machines or really any objects serving any purpose in English. good bad or indifferent. We should remove the word "Generative" to simplify this further. "produce output" reads as rather a diss on AI models and agentic harnesses that belittles their (non-personified) capabilities that would make for a somewhat dated feeling policy. "results" is more what people are looking for and encompasses all sorts of actions taken. I don't like saying "produce output" for the same reason that "generative" doesn't quite have the right ring to it. Internally things done by agentic AI are is technically "output" in the output tokens turning into tool calls that iteratively converge on the goals we asked for sense. But AI users see the end result rather than how it happened inside.
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. "produce output quickly" is pretty different from the original intent of this sentence, which to me is talking about the rate of change of tools themselves The speed of generation is not really relevant in my mind, but the acknowledgement that our guidelines may not contain everything that is most helpful to the reader in whatever latest state of the world they find themself in is
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @gpshead @hauntsaninja When I originally authored the doc back in October 2024, the industry and tool availability was very different than today. I think it makes good sense to drop the term Generative AI in most of this document and go with the simpler term "AI tools".
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||||||||||
| contribution is the responsibility of the contributor. We value good code, concise accurate documentation, | ||||||||||||||
|
|
@@ -36,7 +36,7 @@ Authors must review the work done by AI tooling in detail to ensure it actually | |||||||||||||
|
|
||||||||||||||
| We expect PR authors to be able to explain their proposed changes in their own words. | ||||||||||||||
|
|
||||||||||||||
| Disclose the use of AI tools in the PR description, and be prepared to explain how the tool was used and what | ||||||||||||||
| Disclosure of the use of AI tools in the PR description, and be prepared to explain how the tool was used and what | ||||||||||||||
| changes it made. | ||||||||||||||
|
|
||||||||||||||
| Whether you are using Generative AI or not, keep the following principles in mind for the quality | ||||||||||||||
|
|
||||||||||||||
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -40,6 +40,7 @@ Guide for contributing to Python: | |||||
| * :ref:`rst-primer` | ||||||
| * :ref:`translating` | ||||||
| * :ref:`devguide` | ||||||
| * :ref:`generative-ai` | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| - | ||||||
| * :ref:`setup` | ||||||
| * :ref:`help` | ||||||
|
|
@@ -49,7 +50,8 @@ Guide for contributing to Python: | |||||
| * :ref:`communication` | ||||||
| * :ref:`gitbootcamp` | ||||||
| * :ref:`devcycle` | ||||||
| - | ||||||
| * :ref:`generative-ai` | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| - | ||||||
| * :ref:`tracker` | ||||||
| * :ref:`triaging` | ||||||
| * :ref:`helptriage` | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.