Thanks to visit codestin.com
Credit goes to github.com

Skip to content

WIP: Mention and link to the macOS readme in the repo. #454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 4, 2022

Conversation

jaraco
Copy link
Member

@jaraco jaraco commented Feb 6, 2019

Fixes #453.

@jaraco jaraco changed the title Mention and link to the macOS readme in the repo. WIP: Mention and link to the macOS readme in the repo. Feb 6, 2019
@jaraco
Copy link
Member Author

jaraco commented Feb 6, 2019

In the ticket, Terry has asked that we defer this link until the link target is updated. I'll file a ticket for that.

@jaraco
Copy link
Member Author

jaraco commented Feb 6, 2019

Blocked on bpo-35905.

@willingc willingc added the status-do not merge Do not merge the PR label Jun 9, 2019
@za
Copy link
Contributor

za commented Oct 29, 2021

Hi @matrixise is there anything else we should fix in the PR?

cc: @jaraco

@ezio-melotti ezio-melotti merged commit 5e918e2 into main Jun 4, 2022
@ezio-melotti ezio-melotti deleted the feature/mention-mac-readme branch June 4, 2022 19:13
@za
Copy link
Contributor

za commented Jun 4, 2022

Thanks @ezio-melotti for merging. We may remove this label: status-do-not-merge #454 (comment)

@AlexWaygood AlexWaygood removed the status-do not merge Do not merge the PR label Jun 4, 2022
@ezio-melotti
Copy link
Member

I thought I commented on this issue, but apparently I forgot to submit after I merged. The README has been updated since this PR was created and I think a link to the README is useful regardless. I therefore decided to go ahead and merge it even if python/cpython#80086 is still open.

AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Jun 17, 2022
* Mention and link to the macOS readme in the repo. Fixes python#453.

* Rename hyperlink to 'macOS readme' to avoid conflict with Windows 'readme'

* Update link to macOS Readme

* Capitalize README.

Co-authored-by: Ezio Melotti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup guide should link to platform readme (macOS)
7 participants