Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update the developer log based on the official historical record #533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2019
Merged

Update the developer log based on the official historical record #533

merged 2 commits into from
Sep 12, 2019

Conversation

brettcannon
Copy link
Member

Closes #390

Co-Authored-By: Petr Viktorin <[email protected]>
@brettcannon brettcannon merged commit 8092ded into python:master Sep 12, 2019
@brettcannon brettcannon deleted the updated-developer branch September 12, 2019 16:39
@aeros
Copy link
Contributor

aeros commented Sep 14, 2019

@brettcannon Could we also add a column to this list that provides a GitHub username for each core developer?

The more long term solution would be to update the experts index as described in #507. But, there has not been any progress from when I opened a PR to create the JSON to store the expert data (GH-507) approx two months ago. In the meantime, it might be a decent option to add the GitHub usernames for all of the core developers that have one to the developer log.

If the information is not available in the private committers repository, I would not mind opening a new PR to complete the process manually. For my own purposes during PR review, it can be quite tedious to find the GitHub username of core developers on the experts index (since that only contains the bpo usernames). We could really use at least one comprehensive list on the devguide.

Edit: The other option would be to open a thread in python-dev, to see if any of the core developers would be able to help with reviewing the JSON's structure, populating the experts index using the JSON, and updating the script that parses the data from the experts index for use on bpo to recognize the new format. Also, I would also like to discuss the removal of inactive experts on the index.

I would be mostly self-sufficient in this process, I just need a core developer interested in periodically reviewing the changes. Let me know what you think.

@brettcannon
Copy link
Member Author

@aeros167 Technically it could be private who is what GitHub username (we have no requirement that you can't have a pseudo-anonymous GitHub account which doesn't expose your real name). Basically someone has to ask the core devs if anyone objects.

@aeros
Copy link
Contributor

aeros commented Sep 19, 2019

@brettcannon:

Basically someone has to ask the core devs if anyone objects.

I'll open up a new thread in python-dev in the near future to gather some feedback on the subject. My idea for this would be to make it an opt-out system, and to initially only include those that have their real name mentioned on their GitHub user page or included as part of their username (such as yours). If anyone doesn't want to be included, we could simply leave the GitHub column for them as empty, null, or an empty string (depending on the implementation details of the csv-table directive).

We definitely could benefit from having a single location where there's a public listing of GitHub usernames for each of the core developers that isn't tied to bpo, since we're working on moving away from there.

@aeros
Copy link
Contributor

aeros commented Sep 19, 2019

If it is accepted, would you prefer for the usernames to be manually added to the .csv so that any developers who don't have their GitHub username associated with their real name or those who wish to opt-out don't mistakenly have their usernames added? From my understanding, this would be the only change needed for the .rst:

.. csv-table::
   :header: "Name", "Joined", "GitHub"
   :file: developers.csv
   :encoding: "utf-8"

It might be a bit tedious, but I think it will ultimately be worthwhile. It'll give me a good chance to familiarize myself with all of the core dev GitHub usernames. I'm familiar with most of the currently active ones at this point, but I'm sure there's several sporadically active ones that I haven't encountered.

@brettcannon
Copy link
Member Author

@aeros167 I really don't want to make this an opt-out system. Either no one will care and we will do it or some people will and so we won't do it since you could infer who is who on GitHub through process of elimination.

And I will handle updating everything if this happens so don't worry about the changes to make (there are other things that may have to change).

@aeros
Copy link
Contributor

aeros commented Sep 19, 2019

@brettcannon:

I really don't want to make this an opt-out system.

I'm good with it either way. I just figured that might simplify things a bit. If it is rejected, the experts index should at least contain GitHub names as well once we get further along on that project. Those are the primary useful GitHub usernames for triagers and PR authors to be aware of, and should definitely be posted somewhere public (outside of bpo).

And I will handle updating everything if this happens so don't worry about the changes to make (there are other things that may have to change).

Okay, sounds good. I figured you already had a decent amount on your plate and could use the assistance, but I have no issues with that. Let me know if you need any help with any part of it though, this particular project is important to me. (:

Also, I'm eager to help with the any part of the general GitHub migration process (if possible). Although bpo seems to have served the Python development community well overall, I very much appreciate a lot of the features on GitHub. Feel free to mention or directly assign me to any related issues that I would be able to help with.

AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify developer log
4 participants