Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Use GitHub usernames in the expert index. #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2022
Merged

Use GitHub usernames in the expert index. #825

merged 2 commits into from
Apr 9, 2022

Conversation

ezio-melotti
Copy link
Member

This PR is a follow-up of #552 and #507. The former added a list of GitHub usernames to developers.csv, but the list wasn't actually used in #507. This PR updates the experts.rst file with the GitHub names.

Some experts didn't have a GitHub username, so I left their bpo username marked with a ^, while others now have one on bpo, so I added it to developers.csv. Note that I just checked bpo for people in the expert list that didn't have a GitHub name in developers.csv -- I didn't try to find their GitHub name through other means and I didn't check other committers that weren't in the expert list. I also updated the preamble and fixed a TODO.

While updating the names, I also found

  • 3 users that are not committers but they are listed in the expert index (pradyunsg, gregorlingl, Marcus.Smith)
  • 10 users that are marked as committers on bpo, but aren't listed in developers.csv (serwy, alanmcintyre, David.Edelsohn, alexis, flowdas, gbtami, rougeth, mattwang44, josix, zhsj -- most of these work on translations)

@ezio-melotti ezio-melotti self-assigned this Apr 1, 2022
@ezio-melotti ezio-melotti mentioned this pull request Apr 1, 2022
Open
58 tasks
brettcannon
brettcannon requested changes Apr 1, 2022
View reviewed changes
@terryjreedy
Copy link
Member

I would remove following inactive people (maybe another issue). (I believe I added the 'inactive' labels to these.)
tkinter: G. Polo was a GSOC student about 2009?, Not active since.
turtle: Gregor Lingl contributed the current turtle.py in about 2009, but has been inactive since, or soon after commit.
Never signed CLA. Said he would about 2015 after 2 emails but did not.
idlelib: Roger Serwy got commit rights in 2013 and merged about 10 IDLE issues soon after. I only remember 1 or 2 comments since.
idlelib: Kurt Kaiser stopped sometime before 2010, and I do not remember seeing anything other than one message since.

@ezio-melotti
Copy link
Member Author

I could remove the ones without a GitHub username in this PR, so I don't have to mark them with a ^ (which might also break the nosy autocomplete of bpo). While I'm at it I could also remove from the expert index the ones you mentioned, or even all the ones marked as (inactive). @brettcannon, what do you think?

@brettcannon
Copy link
Member

I don't really have an opinion as I don't use this file.

@ezio-melotti
Copy link
Member Author

I used the generated developers.csv to replace the one I had created, and the only difference seems to be with some whitespace. We can merge this after the GitHub migration, since in its current form it might break the nosy autocomplete on bpo.

@ezio-melotti ezio-melotti merged commit 15eb5b7 into python:main Apr 9, 2022
@ezio-melotti ezio-melotti deleted the update-experts-gh branch April 9, 2022 21:28
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Jun 17, 2022
@ezio-melotti
Use GitHub usernames in the expert index. (python#825)
3bcde02 
* Use GitHub usernames in the expert index.

* Replace developers.csv with the generated version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brettcannon brettcannon brettcannon requested changes

@Mariatta Mariatta Awaiting requested review from Mariatta

Assignees

@ezio-melotti ezio-melotti

Labels
CLA signed enhancement github
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ezio-melotti @terryjreedy @brettcannon @the-knights-who-say-ni