Fix faulty logic for success/failure comment #576
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #576 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 1025 1032 +7
Branches 72 72
=========================================
+ Hits 1025 1032 +7
|
ezio-melotti
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #565 (comment)
The logic introduced in #565 was not correct as the
if ... if ... elsewas place incorrectly.I didn't catch this as the previous tests don't actually test for the actual message being commented, but only check if a comment is being posted. This fixes this and updates all test that check for comment posting in the
status_changetests.Pinging @ezio-melotti for a review.
Sorry for the confusion caused! I should have seen this gap in the tests when I first worked on this issue.