Thanks to visit codestin.com
Credit goes to github.com

Skip to content

stubtest crashes when testing django-types #12931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
last-partizan opened this issue Jun 2, 2022 · 1 comment · Fixed by #13160
Closed

stubtest crashes when testing django-types #12931

last-partizan opened this issue Jun 2, 2022 · 1 comment · Fixed by #13160
Labels
crash topic-stubtest

Comments

@last-partizan
Copy link

Hello.

I want to veryfy django-types with stubtest. But it crashes with following message:

Traceback

Traceback (most recent call last):
  File "/home/serg/.cache/pypoetry/virtualenvs/django-types-BW7xHCiR-py3.10/bin/stubtest", line 8, in <module>
    sys.exit(main())
  File "/home/serg/.cache/pypoetry/virtualenvs/django-types-BW7xHCiR-py3.10/lib/python3.10/site-packages/mypy/stubtest.py", line 1260, in main
    return test_stubs(parse_options(sys.argv[1:]))
  File "/home/serg/.cache/pypoetry/virtualenvs/django-types-BW7xHCiR-py3.10/lib/python3.10/site-packages/mypy/stubtest.py", line 1153, in test_stubs
    for error in test_module(module):
  File "/home/serg/.cache/pypoetry/virtualenvs/django-types-BW7xHCiR-py3.10/lib/python3.10/site-packages/mypy/stubtest.py", line 180, in test_module
    yield from verify(stub, runtime, [module_name])
  File "/home/serg/.cache/pypoetry/virtualenvs/django-types-BW7xHCiR-py3.10/lib/python3.10/site-packages/mypy/stubtest.py", line 229, in verify_mypyfile
    yield from verify(
  File "/home/serg/.cache/pypoetry/virtualenvs/django-types-BW7xHCiR-py3.10/lib/python3.10/site-packages/mypy/stubtest.py", line 698, in verify_var
    if isinstance(runtime, Missing):
  File "/home/serg/.cache/pypoetry/virtualenvs/django-types-BW7xHCiR-py3.10/lib/python3.10/site-packages/django/utils/functional.py", line 240, in inner
    self._setup()
  File "/home/serg/.cache/pypoetry/virtualenvs/django-types-BW7xHCiR-py3.10/lib/python3.10/site-packages/django/contrib/admin/sites.py", line 540, in _setup
    AdminSiteClass = import_string(apps.get_app_config('admin').default_site)
  File "/home/serg/.cache/pypoetry/virtualenvs/django-types-BW7xHCiR-py3.10/lib/python3.10/site-packages/django/apps/registry.py", line 154, in get_app_config
    self.check_apps_ready()
  File "/home/serg/.cache/pypoetry/virtualenvs/django-types-BW7xHCiR-py3.10/lib/python3.10/site-packages/django/apps/registry.py", line 136, in check_apps_ready
    raise AppRegistryNotReady("Apps aren't loaded yet.")
django.core.exceptions.AppRegistryNotReady: Apps aren't loaded yet.

To Reproduce

Clone django-types, install django and mypy, run stubtest django from django-types directory.

Problem

Main problem in this case - is django refusing to work without explicit setup, and django-stubs fixes it with their mypy_django_plugin, but django-types doesn't use that plugin.

What do you think, how to fix this error?

I propose doing something like this:

From 513d6a3655634074c7894168efb92e689bf950f1 Mon Sep 17 00:00:00 2001
From: Serg Tereshchenko <[email protected]>
Date: Thu, 2 Jun 2022 20:38:05 +0300
Subject: [PATCH] fix: Handle runtime errors during verification

---
 mypy/stubtest.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/mypy/stubtest.py b/mypy/stubtest.py
index a85e9335a..ad0a7e78d 100644
--- a/mypy/stubtest.py
+++ b/mypy/stubtest.py
@@ -187,7 +187,10 @@ def test_module(module_name: str) -> Iterator[Error]:

     with warnings.catch_warnings():
         warnings.simplefilter("ignore")
-        yield from verify(stub, runtime, [module_name])
+        try:
+            yield from verify(stub, runtime, [module_name])
+        except Exception as err:
+            yield Error([module_name], f"Runtime error: {err}", stub, runtime)


 @singledispatch
--
2.36.1

I could hide this behaviour behind a flag, if you don't think this should be default. But this is really helpful for testing django stubs, unless we can find other ideas.
@AlexWaygood
Copy link
Member

Cc. @hauntsaninja

@hauntsaninja hauntsaninja mentioned this issue Jun 8, 2022
Closed
hauntsaninja added a commit to hauntsaninja/mypy that referenced this issue Jul 17, 2022
@hauntsaninja
stubtest: catch all for errors from the runtime
83f798e 
Fixes python#12931
@hauntsaninja hauntsaninja mentioned this issue Jul 17, 2022
Merged
hauntsaninja added a commit that referenced this issue Jul 18, 2022
@hauntsaninja
stubtest: catch all for errors from the runtime (#13160)
111a7da 
Fixes #12931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
crash topic-stubtest
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stubtest: catch all for errors from the runtime hauntsaninja/mypy
2 participants
@last-partizan @AlexWaygood