Tuple multiply literal - #10361
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
Member
|
mypy-primer found it crashing at https://github.com/google/jax/blob/master/jax/_src/lax/other.py#L96, apparently on a |
Contributor
Author
|
Fixed in commit. I think at least. It doesn't comment if no diff.
…On Fri, Apr 23, 2021, 17:12 Jelle Zijlstra ***@***.***> wrote:
mypy-primer found it crashing at
https://github.com/google/jax/blob/master/jax/_src/lax/other.py#L96,
apparently on a Tuple[int, ...].
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#10361 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACYQXXOEHDGRBDFPVU3MTNDTKF56LANCNFSM43OR2TWQ>
.
|
JukkaL
reviewed
Apr 23, 2021
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the PR! Looks good, I'd just prefer to have these tests use the test fixtures instead of full stubs, since tests using full stubs are a lot slower to run.
Contributor
Author
|
Done as requested. |
JukkaL
reviewed
May 5, 2021
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the updates! Looks good based on a quick review pass.
Since we are (hopefully) close to a mypy release, I won't merge this until I've cut a release branch. Changes to type inference frequently have hard-to-find edge cases, so I'd prefer to merge this early in a release process to that there will be more time for testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #863.
I've added a method hook that given an int literal multiplied by a tuple gives the correct specific sized tuple.
Test Plan
I've added more python evaulation tests and mypy_primer should cover enough of a regression test.