[mypyc] Add a special case for str_rprimitive in builder.builtin_len - #10710
Merged
Conversation
TH3CHARLie
reviewed
Jun 25, 2021
97littleleaf11
commented
Jun 28, 2021
| source_str = 'abbc' | ||
| b = tuple('s:' + x for x in source_str) | ||
| assert b == ('s:a', 's:b', 's:b', 's:c') | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
I made a mistake last week that a cannot be assigned to Tuple[str...].
|
|
||
| [case testTupleBuiltFromList2] | ||
| [case testTupleBuiltFromStr] | ||
| def f2(val: str) -> str: |
Collaborator
Author
There was a problem hiding this comment.
There is another testTupleBuiltFromList thus it's redundant.
Collaborator
|
Can you double check the perf impact by running some quick microbenchmark? |
Collaborator
Author
|
This branch: Master branch: Tested on: def list_from_str() -> None:
s1 = "aaaaa"
n = 0
for i in range(1000):
list = [x for x in s1]
n += len(list)
assert n == 5000, n |
Collaborator
Author
|
Adding a wrapper function has little impact on performance, since the speed up is based on the optimized list comprehension: |
JukkaL
reviewed
Jun 30, 2021
JukkaL
approved these changes
Jul 1, 2021
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! Thanks for the updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes mypyc/mypyc#835
str_rpimitiveinbuiltin_lenTest Plan