stubgen: Add support for yield statements - #10745
Merged
Merged
Conversation
srittau
commented
Jun 30, 2021
|
|
||
| The import will be internal to the stub. | ||
| """ | ||
| name = self.typing_name(name) |
Contributor
Author
There was a problem hiding this comment.
The name typing_name is not really correct anymore, since we use it for collections.abc as well. Should we rename it?
Member
There was a problem hiding this comment.
I don't feel strongly, it's still a typing concept even if it lives in collections.abc.
JelleZijlstra
approved these changes
Jun 30, 2021
Contributor
Author
|
Gentle pingedy pong. |
Member
|
Thanks! I even ran into this when writing the beautifulsoup stubs the other day :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stubgen: Support functions that yield values:
will be generated as:
Before this change, these function were annotated with a
Nonereturn type.This PR doesn't support
yield fromexpressions (see #10744).Test Plan
Tests for this feature and a few corner cases were added.