[mypyc] Implement bytes equality optimizations - #10928
Merged
Merged
Conversation
msullivan
approved these changes
Aug 5, 2021
msullivan
left a comment
Collaborator
There was a problem hiding this comment.
This looks good, though a test failure needs to be investigated
Collaborator
Oh, the function needs declared in |
Collaborator
|
Can you also merge master? There are merge conflicts. |
25 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements part of mypyc/mypyc#880.
Implementation for the bytes comparison itself is stolen from the implementation of
bytes_comparefrom cpython and inlined.Later we can switch unicode to use a similar API
Test Plan
Added both IR tests and runtime tests. Made a custom benchmark that yielded performance gain of around 4x (from 2.3x faster to 9x faster than uncompiled vs master).