[mypyc] Faster len(bytes) - #10936
Merged
Merged
Conversation
JukkaL
reviewed
Aug 5, 2021
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, just one nit about the IR build test case.
|
|
||
|
|
||
| [case testBytesJoin] | ||
| [case testBytesOps] |
Collaborator
There was a problem hiding this comment.
It would be better to have a separate test case for len(), since irbuild tests are fast to run. Small test cases are generally easier to maintain.
It's important to not have too many small run tests, however, since they have a lot of fixed overhead.
JukkaL
approved these changes
Aug 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Similar to list and tuple, we can directly get length of bytes from
PyVarObject->ob_sizeImplements part of mypyc/mypyc#880.
Test Plan