[mypyc] Add primitive for bytes slicing - #10966
Merged
Merged
Conversation
Collaborator
Author
|
Implements part of mypyc/mypyc#880 |
JukkaL
reviewed
Aug 11, 2021
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Nice! Looks good -- I measured over 2x improvement in the bytes_slicing microbenchmark. I just have a few ideas about more test cases.
25 tasks
JukkaL
approved these changes
Aug 12, 2021
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks! This is ready to merge after the builds are green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a C helper function for
bytesandbytearrayslicing.Test Plan
bytesandbytearraywith return type checks.