Adds better NamedTuple error messages - #11127
Merged
Merged
Conversation
| from collections import namedtuple | ||
|
|
||
| X = namedtuple('X', 'x, _y, _z') # E: namedtuple() field names cannot start with an underscore: _y, _z | ||
| X = namedtuple('X', 'x, _y, _z') # E: "namedtuple()" field names cannot start with an underscore: _y, _z |
Member
There was a problem hiding this comment.
Why did you add the extra quotes? They feel unnecessary.
Member
Author
There was a problem hiding this comment.
Most of the time mypy highlights the most important code part with "", this feels more similar to other cases. For example, here's how it renders in my terminal (with / without ""):
In my opinion, the first one looks and reads better.
Collaborator
There was a problem hiding this comment.
The double quotes look reasonable to me. Previously we didn't use them probably because the () suffix makes it look like code, it seems okay to add them.
JukkaL
approved these changes
Sep 21, 2021
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, just one style nit (optional).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #11047 I've noticed that
mypyreports the same error for bothcollection.namedtuple()andtyping.NamedTuple().I've tried to fix to report the correct name.