Rename MemberContext.builtin_type with named_type - #11224
Merged
JukkaL merged 1 commit intoOct 1, 2021
Conversation
JukkaL
approved these changes
Oct 1, 2021
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Makes sense! builtin_type has been deprecated, so this makes things more consistent and clearer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently
TypeChecker.named_typeis been called insideMemberContext.builtin_typethus this PR renamesMemberContext.builtin_typewithnamed_typefor consistency.Another reason for this change is that we sometimes call this function for non-builtins.