Disallow invalid identifiers from getting implicit bazel __init__.py - #11268
Merged
Conversation
This helps unblock python#9636. With namespace packages, the code to crawl upward would not stop anywhere and would run into temp directories with invalid module names. Normally it would stop when it found a dir without an __init__.py, but it was placing an implicit fake bazel __init__ there. Bazeled environments can't really have invalid module name directories, so this should help fix. Added tests for namespace-packages and no-namespace-packages
hauntsaninja
approved these changes
Oct 4, 2021
hauntsaninja
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thank you!
(It looks like we only check .py files here, so we don't have to worry about xxx-stubs being an invalid identifier but valid package)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This helps unblock #9636. With namespace packages, the
code to crawl upward would not stop anywhere and would
run into temp directories with invalid module names. Normally
it would stop when it found a dir without an init.py,
but it was placing an implicit fake bazel init there.
Bazeled environments can't really have invalid module name
directories, so this should help fix.
Added tests for namespace-packages and no-namespace-packages