Skip checking number of interpolations for string formatting when rhs_type is an Iterable type - #11319
Merged
Merged
Conversation
JukkaL
reviewed
Oct 13, 2021
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Hmm it would be more consistent to not complain about iterable types as the RHS, since the number of items could be correct. For example, mypy doesn't complain about this code, which feels quite similar:
a = [1]
x, y = a # No error, since the number of items could be 2 (mypy doesn't know)
Collaborator
|
For a cleaner commit history, it would be nice to have a separate PR that moves the test cases to a new file. If the refactoring is included with the functionality change and somebody would look at the commit history, it could be a little difficult to find the new test case. This is one reason why I usually prefer refactorings in separate PRs. |
JukkaL
approved these changes
Oct 14, 2021
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for the updates! Looks good.
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
…_type is an Iterable type (python#11319) Closes python#7764
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #7764
Test Plan