move mypyc to console_scripts - #11494
Merged
Merged
Conversation
TH3CHARLie
approved these changes
Nov 8, 2021
TH3CHARLie
left a comment
Collaborator
There was a problem hiding this comment.
Looks good! @ethanhs would you please verify this on Windows as well? Thanks!
Contributor
|
I can confirm that this works correctly on my Windows computer. |
Collaborator
|
@imba-tjd Are you interested in improving mypyc's overall command line functionality? I think it will be a great follow-up issue to work on after this PR. I have a (long stuck) PR that I haven't found time to finish trying to address the problem: #10395. If you are interested, I can guide you to work on that. |
Contributor
Author
|
no, I'm working on 考研😂
|
Collaborator
|
I see, good luck with your graduate school entrance exam. |
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
Description See mypyc/mypyc#893
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See mypyc/mypyc#893
Test Plan
Works for me on Windows.