Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Better error message for nested TypedDict #11658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
97littleleaf11 merged 3 commits into from
Dec 3, 2021
Merged

Better error message for nested TypedDict #11658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
54424d2
better message for inline defined TypedDict
97littleleaf11 Dec 3, 2021
d8256bb
Fix
97littleleaf11 Dec 3, 2021
11e8be8
Modify error msg
97littleleaf11 Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion mypy/semanal_typeddict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,14 @@ def parse_typeddict_fields_with_types(
type = expr_to_unanalyzed_type(field_type_expr, self.options,
self.api.is_stub_file)
except TypeTranslationError:
self.fail_typeddict_arg('Invalid field type', field_type_expr)
if (isinstance(field_type_expr, CallExpr) and
isinstance(field_type_expr.callee, RefExpr) and
field_type_expr.callee.fullname in TPDICT_NAMES):
self.fail_typeddict_arg(
'Inline TypedDict types not supported; use assignment to define TypedDict',
field_type_expr)
else:
self.fail_typeddict_arg('Invalid field type', field_type_expr)
return [], [], False
analyzed = self.api.anal_type(type)
if analyzed is None:
Expand Down
8 changes: 8 additions & 0 deletions test-data/unit/check-typeddict.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,14 @@ Point = TypedDict('Point', {'x': int, 'y': int})
p = Point(x='meaning_of_life', y=1337) # E: Incompatible types (expression has type "str", TypedDict item "x" has type "int")
[builtins fixtures/dict.pyi]

[case testCannotCreateTypedDictInstanceWithInlineTypedDict]
from mypy_extensions import TypedDict
D = TypedDict('D', {
'x': TypedDict('E', { # E: Inline TypedDict types not supported; use assignment to define TypedDict
'y': int
})
})
[builtins fixtures/dict.pyi]

-- Define TypedDict (Class syntax)

Expand Down