Cope with OSError when checking cache stat.mtime - #11718
Merged
Merged
Conversation
hauntsaninja
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, mind adding logging along the new return paths?
If we get an error when accessing the mtime of a cache file, we should handle that as if the cache is unusable for any other reason.
Zac-HD
force-pushed
the
handle-stat-failures
branch
from
December 12, 2021 06:16
ef7e7b5 to
1f32982
Compare
JelleZijlstra
approved these changes
Dec 12, 2021
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
If we get an error when accessing the mtime of a cache file, we should handle that as if the cache is unusable for any other reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we get an error when accessing the mtime of a cache file, we should handle that as if the cache is unusable for any other reason.
I've been getting a bizzare crash here in while working on Hypothesis deps; I think it's something to with with my WSL+pyenv install breaking. Given that there was already a
TODOcomment requesting error handling here, I went ahead and added it in the obvious way.