Display ellipsis when formatting variadic tuple[T, ...] - #11857
Merged
Conversation
Previously variadic tuples were displayed as `builtins.tuple[T]`, which is misleading. That syntax ordinarily indicates a tuple with a single element. This change adds the `...` ellipsis when formatting. The formatting of non-variadic tuples is unchanged (e.g. `Tuple[T, U, V]`).
intgr
commented
Dec 28, 2021
| s += '[{}]'.format(self.list_str(t.args)) | ||
| if t.type.fullname == 'builtins.tuple': | ||
| assert len(t.args) == 1 | ||
| s += '[{}, ...]'.format(self.list_str(t.args)) |
Contributor
Author
There was a problem hiding this comment.
This can also be written as .format(t.args[0].accept(self)), but this seems prettier.
sobolevn
approved these changes
Dec 29, 2021
hauntsaninja
approved these changes
Dec 29, 2021
tushar-deepsource
pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
Previously variadic tuples were displayed as `builtins.tuple[T]`, which is misleading. That syntax ordinarily indicates a tuple with a single element. This change adds the `...` ellipsis when formatting. The formatting of non-variadic tuples is unchanged (e.g. `Tuple[T, U]`). Fixes python#9522
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Previously variadic tuples were displayed as
builtins.tuple[T], whichis misleading. That syntax ordinarily indicates a tuple with a single
element. This change adds the
...ellipsis when formatting.Result:
The formatting of non-variadic tuples is unchanged (e.g.
Tuple[T, U]).Fixes #9522
Test Plan
Lots of coverage for this already in the test suite, see test file diffs.