stubgen: fixed handling of Protocol and added testcase #12129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Feb 5, 2022
| [case testProtocol_semanal] | ||
| from typing import Protocol | ||
|
|
||
| class P(Protocol): |
There was a problem hiding this comment.
Let's also add a generic Protocol[T] class here 🤔
There was a problem hiding this comment.
You mean like this?
T = TypeVar('T')
class PT(Protocol[T]):
def f(self, x: T) -> T:
...That results in:
T = TypeVar('T')
class PT(Protocol):
def f(self, x: T) -> T: ...So I guess that needs to be handled explicitly in my implementation?
This comment has been minimized.
This comment has been minimized.
|
@srittau do you want to double check this? I've seen multiple your PRs to |
|
Any updates on this? :) |
raghavthind2005
approved these changes
Mar 15, 2022
|
If you fix the merge conflict I can review it and hopefully merge it. |
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JelleZijlstra
approved these changes
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #12072 by correctly handling
Protocoldefinitions. Previously, theProtocolbase class was removed when generating type stubs which causes problems with other packages that want to use type definition (because they see it as a regular class, not as aProtocol).Test Plan
Added a testcase to the stubgen testset.