Fix module and protocol subtyping, module hasattr - #13778
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
hauntsaninja
marked this pull request as ready for review
September 30, 2022 05:52
This comment has been minimized.
This comment has been minimized.
1 similar comment
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: sphinx (https://github.com/sphinx-doc/sphinx)
+ sphinx/util/inspect.py:361: error: Unused "type: ignore" comment
+ sphinx/util/inspect.py:364: error: Unused "type: ignore" comment
+ sphinx/util/inspect.py:367: error: Unused "type: ignore" comment
+ sphinx/util/compat.py:21: error: Unused "type: ignore" comment
pylint (https://github.com/pycqa/pylint)
+ pylint/checkers/utils.py:286: error: Unused "type: ignore" comment
+ pylint/checkers/utils.py:286: error: Unsupported right operand type for in (Module) [operator]
+ pylint/checkers/utils.py:286: note: Error code "operator" not covered by "type: ignore" comment
werkzeug (https://github.com/pallets/werkzeug)
+ src/werkzeug/_reloader.py:23: error: Unused "type: ignore" comment
anyio (https://github.com/agronholm/anyio)
+ src/anyio/streams/tls.py:108: error: Unused "type: ignore" comment
bokeh (https://github.com/bokeh/bokeh)
+ src/bokeh/core/templates.py:78: error: Unused "type: ignore" comment
|
ilevkivskyi
approved these changes
Sep 30, 2022
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
LG, thanks! (see however my comment in the issue)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13771 (comment)