Update the fast parser to work with Python 2.7 #1418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| import typed_ast # type: ignore | ||
| from typed_ast import ast27 # type: ignore | ||
| from typed_ast import ast35 # type: ignore | ||
| from typed_ast import conversions # type: ignore |
There was a problem hiding this comment.
Maybe you could provide stubs for these? The untypedness here kind of concerns me.
|
Mostly LGTM, would like your response to the review feedback so far. Generic comment: maybe instead of changing every place that tests for StrExpr to now check for StrExpr or BytesExpr, perhaps those should be the same class with a flag field to distinguish the two? (And why isn't UnicodeExpr also included?) |
|
If you rebase, the typeshed sync will be in and then maybe the tests will pass (or give useful info). |
|
Build passed! |
|
RE: StrExpr vs BytesExpr, I think it makes sense to keep them as-is because there's a separate Str vs Bytes in the Python 3 ast, which we'll hopefully be switching to soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next step for #1353.