Fix Unpack imported from typing#14378
Merged
JelleZijlstra merged 2 commits intopython:masterfrom Jan 2, 2023
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
| return None | ||
| return unbound.name, sym.node | ||
| if sym and sym.fullname == "typing_extensions.Unpack": | ||
| if sym and sym.fullname in {"typing.Unpack", "typing_extensions.Unpack"}: |
Member
There was a problem hiding this comment.
Suggested change
| if sym and sym.fullname in {"typing.Unpack", "typing_extensions.Unpack"}: | |
| if sym and sym.fullname in ("typing.Unpack", "typing_extensions.Unpack"): |
Nit, but this is what most other similar checks look like and I suspect mypyc handles it better. It's likely also faster in non-compiled Python to use a tuple here.
Collaborator
Author
There was a problem hiding this comment.
Not sure about mypyc, but for non-compiled Python it's actually a toss-up for two items. However, starting with three, sets are usually better.
Member
There was a problem hiding this comment.
I ran some local benchmarks and set is faster even for two-element tuples when the element is the second one. Still, better to be consistent with the other mypy code.
Co-authored-by: Jelle Zijlstra <[email protected]>
JelleZijlstra
approved these changes
Jan 2, 2023
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing check for
typing.Unpackto fix running with--python 3.11.