Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support type stub generation for staticmethod #14934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 13 commits into from
Jan 8, 2024
Merged

Support type stub generation for staticmethod #14934

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
bb15d87
Add test for static methods of pybind11 class
Mar 21, 2023
feebc70
Fix is_staticmethod for c modules
Nov 7, 2023
a634dee
Updated stub files for stubgen test
Nov 7, 2023
cae94e6
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Nov 7, 2023
1aacfcc
Fix failing type check
Nov 7, 2023
32389c1
Merge branch 'support_staticmethod' of https://github.com/WeilerMarce…
Nov 7, 2023
8142772
dummy
Nov 7, 2023
bc42c57
dummy to rerun unstable macos tests
Nov 8, 2023
8121e3c
Simplify is_staticmethod check
Nov 9, 2023
2504078
Add type hint for mapping proxies
Nov 15, 2023
e33685c
Merge remote-tracking branch 'origin/master' into support_staticmethod
Dec 4, 2023
e6f61ec
Fix stubgenc docstring test
Dec 5, 2023
14fd95c
Replace string comparison by isinstance
Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Replace string comparison by isinstance
  • Loading branch information
Marcel Weiler committed Jan 8, 2024
commit 14fd95c8cc78df421e91e1144da7381177eefa96
2 changes: 1 addition & 1 deletion mypy/stubgenc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,7 @@ def is_staticmethod(self, class_info: ClassInfo | None, name: str, obj: object)
elif self.is_c_module:
raw_lookup: Mapping[str, Any] = getattr(class_info.cls, "__dict__") # noqa: B009
raw_value = raw_lookup.get(name, obj)
return type(raw_value).__name__ == "staticmethod"
return isinstance(raw_value, staticmethod)
else:
return isinstance(inspect.getattr_static(class_info.cls, name), staticmethod)

Expand Down