-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
(π) ci: include more of the primer comment #15032
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
7e53f76
to
ac4fe74
Compare
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All -
s, nice!
Obligatory links:
|
Actually, are you sure that KotlinIsland/basedmypy#357 (comment) is pushing the limit? In particular, in #14059 there are two issues being discussed:
|
Trial and error shows that this is the longest comment GitHub would accept: python3 -c 'print("x" * (2**18 - 2))' | pbcopy Meanwhile, the UI says the maximum length is 65,535 characters, which is probably isn't far from the truth when taking Unicode into consideration. |
ac4fe74
to
312b609
Compare
Ergh, I knew it was too good to be true :(. So basically the problem with the current solution is that I don't see all the diff, I can see three solutions:
I've updated this PR to meet option 1, happy to accept other ideas. |
According to mypy_primer, this change has no effect on the checked open source code. π€π |
A "core dump" in a comment is not what comments were made for, so GitHub's UI is not particularly accommodating for that use case, and it can also interfere with our normal communications around PRs in comments. Maybe opt for shorter output that only gives a "taste" for what changed, and a link to the artifact download URL, e.g. |
I think that linking to a downloadable zip is not an idea UX (although would be an improvement). What if we always put the changes in a |
Also check that "Details" don't slow down scrolling etc. (And then maybe Details per project?) |
I like the idea of including a link to artifact download if we truncated things. |
I don't think you need to truncate the primer comment anymore.
proof: here we have applied the same change, removing the truncation of the comment, which is having no issue commenting the full-form of the diff.