Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Generates error when staticmethod and classmethod decorators are both used #15118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JukkaL merged 6 commits into from
Apr 24, 2023
Merged

Generates error when staticmethod and classmethod decorators are both used #15118

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
073cbf9
Add test case for both classmethod and staticmethod
jkchandalia Apr 24, 2023
8b868c9
Update message to raise
jkchandalia Apr 24, 2023
adfb755
Update message
jkchandalia Apr 24, 2023
1e95381
Add msg to registry
jkchandalia Apr 24, 2023
317aca6
Add message raising line
jkchandalia Apr 24, 2023
b0de626
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Apr 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add message raising line
  • Loading branch information
@jkchandalia
jkchandalia committed Apr 24, 2023
commit 317aca6df772338c2480bb7caaa4d80fa29603de
2 changes: 2 additions & 0 deletions mypy/semanal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1548,6 +1548,8 @@ def visit_decorator(self, dec: Decorator) -> None:
self.fail("Only instance methods can be decorated with @property", dec)
if dec.func.abstract_status == IS_ABSTRACT and dec.func.is_final:
self.fail(f"Method {dec.func.name} is both abstract and final", dec)
if dec.func.is_static and dec.func.is_class:
self.fail(message_registry.CLASS_PATTERN_CLASS_OR_STATIC_METHOD, dec)

def check_decorated_function_is_method(self, decorator: str, context: Context) -> None:
if not self.type or self.is_func_scope():
Expand Down