Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Do not install tomli for Python>=3.11 - #15504

Closed
sobolevn wants to merge 1 commit into
masterfrom
sobolevn-patch-4
Closed

Do not install tomli for Python>=3.11#15504
sobolevn wants to merge 1 commit into
masterfrom
sobolevn-patch-4

Conversation

@sobolevn

Copy link
Copy Markdown
Member

Now it is in sync with setup.py and pyproject.toml
Refs #15501

Now it is in sync with `setup.py` and `pyproject.toml`
@AlexWaygood

Copy link
Copy Markdown
Member

This breaks the self-check for developers who use Python 3.11 locally, I think

@AlexWaygood

AlexWaygood commented Jun 23, 2023

Copy link
Copy Markdown
Member

This breaks the self-check for developers who use Python 3.11 locally, I think

It was specifically added in #14492. We need it because python_version is always set to 3.7 when running the self-check:

python_version = 3.7

But the 3.7 branches don't type-check if you haven't got tomli installed.

@sobolevn sobolevn closed this Jun 23, 2023
@github-actions

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants