Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[mypyc] Fix 3.12 issue with pickling of instances with __dict__ #15574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JukkaL merged 1 commit into from
Jul 3, 2023
Merged

[mypyc] Fix 3.12 issue with pickling of instances with __dict__ #15574

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[mypyc] Fix 3.12 issue with pickling of instances with __dict__ 
This fixes the testPickling test case in mypyc/test-data/run-classes.test
on Python 3.12.

Handle another case that was missed in #15471. On 3.12 we rely on
Py_TPFLAGS_MANAGED_DICT and shouldn't define an explicit `__dict__`
member.

Work on mypyc/mypyc#995.
  • Loading branch information
@JukkaL
JukkaL committed Jul 3, 2023
commit 8ea9f29d7d36b49299bb7a9b6e08400a8a3aeaec
2 changes: 1 addition & 1 deletion mypyc/codegen/emitclass.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ def emit_line() -> None:
# that isn't what we want.

# XXX: there is no reason for the __weakref__ stuff to be mixed up with __dict__
if cl.has_dict:
if cl.has_dict and not has_managed_dict(cl, emitter):
# __dict__ lives right after the struct and __weakref__ lives right after that
# TODO: They should get members in the struct instead of doing this nonsense.
weak_offset = f"{base_size} + sizeof(PyObject *)"
Expand Down