Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bump PYTHON3_VERSION_MIN to 3.7 #15668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 7 commits into from
Jul 15, 2023
Merged

Bump PYTHON3_VERSION_MIN to 3.7 #15668

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4e39c54
Bump `PYTHON3_VERSION_MIN` to `3.7`
sobolevn Jul 14, 2023
832a97f
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 14, 2023
117901c
Fix `is_stub` logic
sobolevn Jul 14, 2023
3c629f4
Fix CI
sobolevn Jul 14, 2023
a9d34ea
Address review
sobolevn Jul 14, 2023
782ffe0
Fix CI
sobolevn Jul 14, 2023
c7be018
Fix CI
sobolevn Jul 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Address review
  • Loading branch information
@sobolevn
sobolevn committed Jul 14, 2023
commit a9d34ea61ed5762fb48555e8a9993aaa54842542
1 change: 1 addition & 0 deletions test-data/unit/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ feature you added. If you added a new `check-*.test` file, it will be autodiscov
Add the test in this format anywhere in the file:

[case testNewSyntaxBasics]
# flags: --python-version 3.10
x: int
x = 5
y: int = 5
Expand Down
7 changes: 5 additions & 2 deletions test-data/unit/check-union-or-syntax.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,8 @@ x: List[int | str]
reveal_type(x) # N: Revealed type is "builtins.list[Union[builtins.int, builtins.str]]"
[builtins fixtures/list.pyi]

[case testUnionOrSyntaxWithQuotedFunctionTypes]
[case testUnionOrSyntaxWithQuotedFunctionTypesPre310]
# flags: --python-version 3.9
from typing import Union
Comment thread
sobolevn marked this conversation as resolved.
def f(x: 'Union[int, str, None]') -> 'Union[int, None]':
reveal_type(x) # N: Revealed type is "Union[builtins.int, builtins.str, None]"
Expand All @@ -78,7 +79,8 @@ def g(x: "int | str | None") -> "int | None":
return 42
reveal_type(g) # N: Revealed type is "def (x: Union[builtins.int, builtins.str, None]) -> Union[builtins.int, None]"

[case testUnionOrSyntaxWithQuotedVariableTypes]
[case testUnionOrSyntaxWithQuotedVariableTypesPre310]
# flags: --python-version 3.9
y: "int | str" = 42
reveal_type(y) # N: Revealed type is "Union[builtins.int, builtins.str]"

Expand Down Expand Up @@ -135,6 +137,7 @@ x: int | None
x: int | None # E: X | Y syntax for unions requires Python 3.10

[case testUnionOrSyntaxInStubFile]
Comment thread
sobolevn marked this conversation as resolved.
# flags: --python-version 3.9
from lib import x
[file lib.pyi]
x: int | None
Expand Down