Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Basic support for decorated overloads #15898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ilevkivskyi merged 6 commits into from
Aug 18, 2023
Merged

Basic support for decorated overloads #15898

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
70666c9
Support decorated overloads
ilevkivskyi Aug 17, 2023
397334f
Fix typo
ilevkivskyi Aug 17, 2023
c6560f4
Reduce noise on broken overloads
ilevkivskyi Aug 17, 2023
c34521d
Try more principled way to detect decorated overloads
ilevkivskyi Aug 17, 2023
a1480e9
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 17, 2023
8b3c538
Refactor code to speed thing up
ilevkivskyi Aug 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix typo
  • Loading branch information
@ilevkivskyi
ilevkivskyi committed Aug 17, 2023
commit 397334f7acdd69f16bd1591aeab584f14083d2e3
2 changes: 1 addition & 1 deletion mypy/semanal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,7 +1155,7 @@ def analyze_overloaded_func_def(self, defn: OverloadedFuncDef) -> None:

if types and (not isinstance(defn.impl, Decorator) or not defn.impl.decorators):
# TODO: should we enforce decorated overloads consistency somehow?
# TODO: how do support decorated overloads in stubs without major slow-down?
# TODO: how to support decorated overloads in stubs without major slow-down?
defn.type = Overloaded(types)
defn.type.line = defn.line

Expand Down