Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Believe more __new__ return types #16020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
+108 −22
Open

Believe more __new__ return types #16020

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4616fa2
Believe arbitrary __new__ return types
hauntsaninja Sep 2, 2023
e2d3a5e
changes
hauntsaninja Sep 2, 2023
2bd91d5
more changes
hauntsaninja Sep 2, 2023
393b303
hacks
hauntsaninja Sep 4, 2023
7b7d76d
fix instantiate
hauntsaninja Sep 4, 2023
aa5df74
clarify comment
hauntsaninja Sep 4, 2023
59a5aee
clarify comment
hauntsaninja Sep 5, 2023
cdccffa
Merge branch 'master' into abide-by-new
JelleZijlstra Jul 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
clarify comment
  • Loading branch information
@hauntsaninja
hauntsaninja committed Sep 4, 2023
commit aa5df74a2e35d6ed44d18288a1580333e7396fdc
2 changes: 1 addition & 1 deletion mypy/checkmember.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,7 +388,7 @@ def analyze_type_callable_member_access(name: str, typ: FunctionLike, mx: Member
# Unfortunately, generic arguments have already been determined for us. We need these,
# see e.g. testGenericClassMethodUnboundOnClass. So just copy them over to our type.
# This does the wrong thing with custom __new__, see testNewReturnType15, but is
# a lesser evil.
# no worse than previous behaviour.
ret_type = bound_arg.copy_modified(args=ret_type.args)
Copy link
Contributor

@ikonst ikonst Sep 5, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can

Suggested change
ret_type = bound_arg.copy_modified(args=ret_type.args)
ret_type = bound_arg.copy_modified()

if you change checkexpr.py's apply_generic_arguments to expand bound_args (not sure if it's correct to do...):

 return callable.copy_modified(
     ret_type=expand_type(callable.ret_type, id_to_type),
+    bound_args=[
+        expand_type(ba, id_to_type) if ba is not None else None
+        for ba in callable.bound_args
+    ],
     variables=remaining_tvars,
     type_guard=type_guard,
 )

self_type = TypeType(ret_type)

Expand Down