Properly strip types that come before a [ - #16139
Open
tbuzzelli wants to merge 6 commits into
Open
Conversation
tbuzzelli
marked this pull request as ready for review
September 18, 2023 19:16
sobolevn
reviewed
Sep 20, 2023
sobolevn
left a comment
Member
There was a problem hiding this comment.
Thanks! But, we would need a test for this change. Looks like this is quite easy to break again in the future :(
Add test for fix to strip_or_import
for more information, see https://pre-commit.ci
Fix unit test to check for proper spaces in output.
for more information, see https://pre-commit.ci
Author
Added a unit test that covers this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16138
The improvements in #14564 updated the regex replace to make sure the surrounding characters were part of the separating characters (
],,,[was omitted. This results in the subtype preceding the[from not properly being replaced.This PR adds
[to the list of characters after the type in the regex replacement and allows proper replacement of the type.