Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support narrowing unions that include type[None]. #16315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 7 commits into from
Jan 14, 2024
Merged

Support narrowing unions that include type[None]. #16315

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
05f2c71
Support narrowing unions that include type[None].
tyralla Oct 23, 2023
1ea576c
Merge branch 'master' into fix/narrow_nonetype
tyralla Oct 23, 2023
32ca5f4
special case `types.NoneType`
tyralla Oct 24, 2023
fc853e9
Merge branch 'master' into fix/narrow_nonetype
tyralla Dec 4, 2023
fe12f7d
Add test case `testNarrowingIsInstanceNoIntersectionWithFinalTypeAndN…
tyralla Dec 5, 2023
58f0562
A little additional effort for `Subclass of "..." and "NoneType" cann…
tyralla Dec 5, 2023
55b2858
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
[pre-commit.ci] auto fixes from pre-commit.com hooks 
for more information, see https://pre-commit.ci
  • Loading branch information
@pre-commit-ci
pre-commit-ci[bot] committed Dec 5, 2023
commit 55b2858e87f041ea463c244cf9d8fddc7a0e0afa
2 changes: 1 addition & 1 deletion mypy/checker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7132,7 +7132,7 @@ def conditional_types_with_intersection(
return yes_type, no_type
for t in possible_target_types:
if isinstance(t, NoneType):
errors.append((f'"{v.type.name}" and "NoneType"', f'"NoneType" is final'))
errors.append((f'"{v.type.name}" and "NoneType"', '"NoneType" is final'))
continue
intersection = self.intersect_instances((v, t), errors)
if intersection is None:
Expand Down