Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Skip expensive repr() in logging call when not needed #16350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JukkaL merged 1 commit into from
Oct 28, 2023
Merged

Skip expensive repr() in logging call when not needed #16350

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Skip expensive repr() in logging call when not needed 
We were spending quite a lot of time in this function when running
tests, based on profiling.
  • Loading branch information
@JukkaL
JukkaL committed Oct 28, 2023
commit 325dadcb419fb2bac8075da85a30925c5754d678
3 changes: 2 additions & 1 deletion mypy/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,8 @@ def _build(
stdout=stdout,
stderr=stderr,
)
manager.trace(repr(options))
if manager.verbosity() >= 2:
manager.trace(repr(options))

reset_global_state()
try:
Expand Down