Apply suggestions from code review

Co-authored-by: Marc Mueller <[email protected]>
python · JelleZijlstra · Mar 1, 2024 · Feb 9, 2024 · Feb 9, 2024 · Feb 10, 2024
commit 1b1e368dabbbd8ef7923b5abcf8027a76b05e0fe
diff --git a/docs/source/error_code_list2.rst b/docs/source/error_code_list2.rst
@@ -558,10 +558,10 @@ because there's no way one can import it.
 
 .. _code-type-is-not-subtype:
 
-Check that TypeIs narrows types [type-is-not-subtype]
+Check that ``TypeIs`` narrows types [type-is-not-subtype]
 -----------------------------------------------------------------
 
-:pep:`742` requires that when a ``TypeIs`` is used, the narrowed
+:pep:`742` requires that when ``TypeIs`` is used, the narrowed
 type must be a subtype of the original type::
 
     from typing_extensions import TypeIs

diff --git a/mypy/subtypes.py b/mypy/subtypes.py
@@ -697,7 +697,7 @@ def visit_callable_type(self, left: CallableType) -> bool:
                 # They are not compatible. See https://github.com/python/mypy/issues/11307
                 return False
             elif right.type_is is not None and left.type_is is None:
-                # Similarly, if one function has typeNarrower and the other does not,
+                # Similarly, if one function has `TypeIs` and the other does not,
                 # they are not compatible.
                 return False
             return is_callable_compatible(

diff --git a/test-data/unit/check-typeis.test b/test-data/unit/check-typeis.test
@@ -285,7 +285,6 @@ main:5: note:          def is_float(self, a: object) -> bool
 [case testTypeIsInAnd]
 from typing import Any
 from typing_extensions import TypeIs
-import types
 def isclass(a: object) -> bool:
     pass
 def ismethod(a: object) -> TypeIs[float]:
@@ -661,7 +660,7 @@ if typeguard(y="42", x=x):
 
 [case testGenericAliasWithTypeIs]
 from typing import Callable, List, TypeVar
-from typing_extensions import TypeIs, TypeAlias
+from typing_extensions import TypeIs
 
 A = Callable[[object], TypeIs[List[T]]]
 def foo(x: object) -> TypeIs[List[str]]: ...