Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Support TypeAliasType #16926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JelleZijlstra merged 18 commits into from
Mar 11, 2024
Merged

Support TypeAliasType #16926

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
f9b3e71
Support `TypeAliasType` explicit call
sobolevn Dec 10, 2023
23acb5c
Fix CI
sobolevn Dec 10, 2023
9612a96
Support type params in type alias type call
hamdanal Feb 17, 2024
9e19087
Update tests
hamdanal Feb 17, 2024
916e686
Merge remote-tracking branch 'upstream/master' into issue-16614
hamdanal Feb 17, 2024
2f30c87
.
hamdanal Feb 17, 2024
310c75d
Address part of CR
hamdanal Feb 20, 2024
7ffa87f
Merge remote-tracking branch 'upstream/master' into issue-16614
hamdanal Feb 20, 2024
c7b6357
Add test requested in CR
hamdanal Feb 20, 2024
5d1da8b
Use Jelle's wording
hamdanal Feb 21, 2024
aaf19dd
Fix unbound PS or TVT in Callable
hamdanal Feb 21, 2024
c020b79
.
hamdanal Feb 21, 2024
994fbb9
Move test to py312
hamdanal Feb 21, 2024
0f13c06
Revert change to analyze_callable_args
hamdanal Feb 22, 2024
99df3dc
Merge branch 'master' into issue-16614
JelleZijlstra Mar 11, 2024
54374a3
Update mypy/semanal.py
JelleZijlstra Mar 11, 2024
ba58bef
Update mypy/semanal.py
JelleZijlstra Mar 11, 2024
a451e66
Update mypy/semanal.py
JelleZijlstra Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use Jelle's wording
  • Loading branch information
@hamdanal
hamdanal committed Feb 21, 2024
commit 5d1da8becb89d9a092267dd7e9bc167cf8a86359
2 changes: 1 addition & 1 deletion mypy/semanal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3829,7 +3829,7 @@ def analyze_type_alias_type_params(self, rvalue: CallExpr) -> TypeVarLikeList:
if isinstance(tvar[1], TypeVarTupleExpr):
if have_type_var_tuple:
self.fail(
"Can only use one type var tuple in type_params argument to TypeAliasType",
"Can only use one TypeVarTuple in type_params argument to TypeAliasType",
base,
code=codes.TYPE_VAR,
)
Expand Down
2 changes: 1 addition & 1 deletion test-data/unit/check-type-aliases.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1152,7 +1152,7 @@ partially_generic1: Ta3[int] = {"a": 1}
reveal_type(partially_generic1) # N: Revealed type is "builtins.dict[Any, builtins.int]"
partially_generic2: Ta3[int] = {1: "a"} # E: Dict entry 0 has incompatible type "int": "str"; expected "Any": "int"

Ta4 = TypeAliasType("Ta4", Tuple[Unpack[Ts]], type_params=(Ts, Ts1)) # E: Can only use one type var tuple in type_params argument to TypeAliasType
Ta4 = TypeAliasType("Ta4", Tuple[Unpack[Ts]], type_params=(Ts, Ts1)) # E: Can only use one TypeVarTuple in type_params argument to TypeAliasType

Ta5 = TypeAliasType("Ta5", Dict) # Unlike old style aliases, this is not generic
Comment thread
JelleZijlstra marked this conversation as resolved.
non_generic_dict: Ta5[int, str] # E: Bad number of arguments for type alias, expected 0, given 2
Expand Down