Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Change end line and column for untyped function defs to line of function definition #17006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mschoettle wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Change end line and column for untyped function defs to line of function definition #17006

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
5f88e5d
Add test for line and column end for missing function type annotation
mschoettle Mar 9, 2024
c780ac1
Change end of line and column to be same as start of node
mschoettle Mar 9, 2024
707e4aa
Merge branch 'python:master' into untyped-def-end-line
mschoettle May 6, 2024
8b7802c
Add end line and column for the function definition itself
mschoettle May 6, 2024
6dee499
Determine end line and column of function itself
mschoettle May 6, 2024
37ee833
Add more tests
mschoettle May 7, 2024
081c8cb
Add extra test case
mschoettle May 7, 2024
b835494
Cleanup
mschoettle May 8, 2024
5a7c0ec
Add multiline test
mschoettle May 9, 2024
38f311a
Merge branch 'master' into untyped-def-end-line
JelleZijlstra Jun 2, 2024
796d6ee
Merge branch 'master' into untyped-def-end-line
mschoettle Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add extra test case
  • Loading branch information
@mschoettle
mschoettle committed May 7, 2024
commit 081c8cb661671453a08934addab799d8e25797c9
15 changes: 15 additions & 0 deletions test-data/unit/check-columns.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,21 @@ main:13:5:13:40: error: Function is missing a type annotation
main:16:5:16:24: error: Function is missing a type annotation
main:19:5:19:36: error: Function is missing a type annotation

[case testColumnEndFunctionMissingTypeAnnotationWithReturnType]
# flags: --disallow-untyped-defs --show-error-end
def f() -> None:
pass

def f_partially_typed(x: int, foo) -> None:
pass

def f_untyped(x, foo, *args, **kwargs) -> None:
pass
[builtins fixtures/tuple.pyi]
[out]
main:5:1:5:43: error: Function is missing a type annotation for one or more arguments
main:8:1:8:47: error: Function is missing a type annotation for one or more arguments

[case testColumnNameIsNotDefined]
((x)) # E:3: Name "x" is not defined

Expand Down