Thanks to visit codestin.com
Credit goes to github.com

Skip to content

attrs: Fix emulating hash method logic #17016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JukkaL merged 2 commits into from
Mar 15, 2024
Merged

attrs: Fix emulating hash method logic #17016

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d40909e
attrs: Fix emulating hash method logic
Hnasar Mar 10, 2024
191cd9f
fixup! attrs: Fix emulating hash method logic
Hnasar Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup! attrs: Fix emulating hash method logic 
Add another test for parameter precedence
  • Loading branch information
@Hnasar
Hnasar committed Mar 12, 2024
commit 191cd9f7943988856df4e8472d8a321dea06657c
15 changes: 15 additions & 0 deletions test-data/unit/check-plugin-attrs.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2460,3 +2460,18 @@ class B(A):
reveal_type(B.__hash__) # N: Revealed type is "None"

[builtins fixtures/plugin_attrs.pyi]

[case testUnsafeHashPrecedence]
from attrs import define, frozen

@define(unsafe_hash=True, hash=False)
class A:
pass
reveal_type(A.__hash__) # N: Revealed type is "def (self: builtins.object) -> builtins.int"

@define(unsafe_hash=False, hash=True)
class B:
pass
reveal_type(B.__hash__) # N: Revealed type is "None"

[builtins fixtures/plugin_attrs.pyi]