Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Give type annotation suggestion for incompatible **kwargs error #17186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andyxzhu wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Give type annotation suggestion for incompatible **kwargs error #17186

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9af2885
Finally found the relevant code, added temporary test file to monitor…
jublizoo Apr 26, 2024
806184f
Added unconditional note for incompatible argument type
jublizoo Apr 26, 2024
fc4b3e2
check for dictionary **dictionary type now functional
jublizoo Apr 27, 2024
0a3403d
Note with argument type checking now functional. More testing is requ…
jublizoo Apr 27, 2024
7460115
Removed unnecesary test annotations and modifications
jublizoo Apr 27, 2024
0ad5c3b
Added support for error messages and test cases
Apr 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added unconditional note for incompatible argument type
  • Loading branch information
@jublizoo
jublizoo committed Apr 26, 2024
commit 806184f3ae2cf19443d72321a48d7b116e4ac913
2 changes: 2 additions & 0 deletions mypy/messages.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,6 +818,8 @@ def incompatible_argument(
quote_type_string(arg_type_str),
quote_type_string(expected_type_str),
)
note_msg = 'Consider using a TypedDict type or "Dict[str, any]" for the ** argument'
notes.append(note_msg)
expected_type = get_proper_type(expected_type)
if isinstance(expected_type, UnionType):
expected_types = list(expected_type.items)
Expand Down