Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Shorter reporting (i.e. don't highlight entire functions for certain errors) #17203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
shaperilio wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

Shorter reporting (i.e. don't highlight entire functions for certain errors) #17203

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10c391b
Compute `end_line` and `end_column` for `FuncDef` so they don't inclu…
shaperilio Jan 6, 2024
618440a
Report end line and column in `SemanticAnalyzer`
shaperilio Jan 6, 2024
070becb
Revert "Compute `end_line` and `end_column` for `FuncDef` so they don…
shaperilio Jan 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 18 additions & 2 deletions mypy/semanal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6520,12 +6520,28 @@ def fail(
return
# In case it's a bug and we don't really have context
assert ctx is not None, msg
self.errors.report(ctx.line, ctx.column, msg, blocker=blocker, code=code)
self.errors.report(
ctx.line,
ctx.column,
msg,
blocker=blocker,
end_line=ctx.end_line,
end_column=ctx.end_column,
code=code,
)

def note(self, msg: str, ctx: Context, code: ErrorCode | None = None) -> None:
if not self.in_checked_function():
return
self.errors.report(ctx.line, ctx.column, msg, severity="note", code=code)
self.errors.report(
ctx.line,
ctx.column,
msg,
severity="note",
end_line=ctx.end_line,
end_column=ctx.end_column,
code=code,
)

def incomplete_feature_enabled(self, feature: str, ctx: Context) -> bool:
if feature not in self.options.enable_incomplete_feature:
Expand Down