Ignore PEP 649 + 695 implementation details in stubtest - #18469
Closed
cdce8p wants to merge 1 commit into
Closed
Conversation
| "__subclasshook__", | ||
| "__subclasscheck__", | ||
| # PEP 695 implementation details | ||
| "__annotate__", |
Member
There was a problem hiding this comment.
__annotate__ is from PEP 649, not 695. __classdictcell__ does come from PEP 695 (so it's already in 3.12+), but is used only during class body execution and I don't think stubtest should see it. Did you encounter problems with it?
Collaborator
Author
There was a problem hiding this comment.
__annotate__is from PEP 649, not 695.__classdictcell__does come from PEP 695 (so it's already in 3.12+), but is used only during class body execution and I don't think stubtest should see it.
Seems I mixed them up again. Sorry about that.
Did you encounter problems with it?
I did ran the test suite with Python 3.14.0a4 yesterday. These were two of the test failures. IIRC they had been there since some time, maybe 3.14.0a1?
___________________________________________________ StubtestUnit.test_named_tuple ___________________________________________________
...
E AssertionError: error: test_module.X1.__annotate__ is not present in stub
E Stub: in file test_module.pyi
E MISSING
E Runtime: in file /.../cpython/Lib/typing.py:2982
E def (format)
E
E error: test_module.X1.__classdictcell__ is not present in stub
E Stub: in file test_module.pyi
E MISSING
E Runtime:
E <cell at 0x108763ee0: dict object at 0x1088a70c0>
E
E error: test_module.X2.__annotate__ is not present in stub
E Stub: in file test_module.pyi
E MISSING
E Runtime: in file /.../cpython/Lib/typing.py:2982
E def (format)
E
E error: test_module.X2.__classdictcell__ is not present in stub
E Stub: in file test_module.pyi
E MISSING
E Runtime:
E <cell at 0x108763490: dict object at 0x1088a6140>
E
E ...
E assert {'test_module...e.X2.__new__'} == {'test_module.X2.__new__'}
E
E Extra items in the left set:
E 'test_module.X1.__classdictcell__'
E 'test_module.X2.__classdictcell__'
E 'test_module.X1.__annotate__'
E 'test_module.X2.__annotate__'
E Use -v to get more diff
mypy/test/teststubtest.py:233: AssertionError
_____________________________________________ StubtestUnit.test_runtime_typing_objects ______________________________________________
...
E AssertionError: error: test_module.X.__annotate__ is not present in stub
E Stub: in file test_module.pyi
E MISSING
E Runtime: in file test_module.py:3
E def (format, /)
E
E Found 1 error (checked 1 module)
E
E assert {'test_module.X.__annotate__'} == set()
E
E Extra items in the left set:
E 'test_module.X.__annotate__'
E Use -v to get more diff
mypy/test/teststubtest.py:233: AssertionError
====================================================== short test summary info ======================================================
FAILED mypy/test/teststubtest.py::StubtestUnit::test_named_tuple - AssertionError: error: test_module.X1.__annotate__ is not present in stub
FAILED mypy/test/teststubtest.py::StubtestUnit::test_runtime_typing_objects - AssertionError: error: test_module.X.__annotate__ is not present in stub
cdce8p
force-pushed
the
stubtest-ignore-695-attributes
branch
from
January 15, 2025 08:22
74647a8 to
c8c9901
Compare
Collaborator
Author
|
Resolved with |
Member
|
Oops, sorry for forgetting about this PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PEP 649 added
__annotate__and PEP 695__classdictcell__. At the moment it looks like 649 will be enabled with 3.14 at which point stubtest would complain about these. It probably makes sense to add them to the ignore list now.