Fix order of steal/unborrow in tuple unpacking - #18732
Merged
Merged
Conversation
JukkaL
approved these changes
Feb 25, 2025
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
I think you are right. This is pretty subtle, but it appears the old logic was wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, although globally the refcount is correct, it may briefly touch 0 if a target of unpacking in unused, e.g.
_, _, last = some_tuple. This can be prevented by placing steal before unborrow (which IMO should be the recommended way, if I understand the logic of these terms correctly).