[mypyc] Support for annotating classes to be native or not (native_class=True/False) - #18802
Merged
Merged
Conversation
svalentin
force-pushed
the
non-extension-class
branch
from
March 14, 2025 22:36
1928a52 to
908c537
Compare
Collaborator
Author
|
Doing |
JukkaL
approved these changes
Mar 28, 2025
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks! Just one idea about a test case.
|
|
||
| @mypyc_attr(native_class=True) | ||
| @decorator | ||
| class NonNativeClassContradiction(): # E: Class is marked as native_class=True but it can't be a native class |
Collaborator
There was a problem hiding this comment.
Test also a successful case of using native_class=True (in a run test so that the runtime behavior can be tested).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.