-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Add a flag --enable-all-error-codes
, which enables all error codes
#19048
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
wyattscarpenter
wants to merge
20
commits into
python:master
Choose a base branch
from
wyattscarpenter:error_code_all
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+149
−15
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
3f952b9
add all error code
wyattscarpenter 31e2b72
formatting fixes
wyattscarpenter c0e6aeb
manual experimentation reveals that this code only works for the comm…
wyattscarpenter 469de61
add a spotcheck test for error code all
wyattscarpenter ccb62cb
oh, right, overrides is in typing_extensions
wyattscarpenter 34d218e
I guess these need tuples
wyattscarpenter 035d4d6
since I'm getting more weird errors, let's try builtins fixtures/prim…
wyattscarpenter 0d50f97
...try typing fixtures/typing-full.pyi
wyattscarpenter b8fbb34
ok now tuple is missing again. so let's try both
wyattscarpenter dd4a343
try tuple simple
wyattscarpenter 787c680
fix all of the test fixture complaints
wyattscarpenter 07710bf
begin pivoting to --enable-all-error-codes
wyattscarpenter 6728040
pivot to --enable-all-error-codes flag
wyattscarpenter 465ea8c
document, and add a new test
wyattscarpenter 9e98209
fix some typos / confusing language I found along the way
wyattscarpenter 0b32309
improve documentation
wyattscarpenter ad5dac3
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 8066787
remember that I was supposed to mention this in --strict
wyattscarpenter 7bae510
allow --enable-all-error-codes to be countermanded
wyattscarpenter bf1fc81
new tests for countermanding
wyattscarpenter File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would also mention that specifing both
--enable-error-code
and--enable-all-error-codes
must be an error. It is either or.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess if I take your previous suggestion about how
--disable-error-code
should supersede, then one could use--enable-all-error-codes --disable-error-code x --enable-error-code x
, which would be no more erroneous than using--disable-error-code x --enable-error-code x
is already. 🤔