Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix nondeterministic type checking caused by nonassociativity of joins #19147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 7 commits into from
May 28, 2025
Merged

Fix nondeterministic type checking caused by nonassociativity of joins #19147

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f02c757
test
hauntsaninja May 25, 2025
62c0399
fix
hauntsaninja May 25, 2025
45fa530
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] May 25, 2025
8b8a3a7
oops
hauntsaninja May 25, 2025
18562b0
fix
hauntsaninja May 25, 2025
ae7b868
makes other test cases a bit better
hauntsaninja May 25, 2025
b2fc336
remove the extra test case
hauntsaninja May 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
test
  • Loading branch information
@hauntsaninja
hauntsaninja committed May 25, 2025
commit f02c757d00e407c677495d098899f950a8a4928b
52 changes: 51 additions & 1 deletion test-data/unit/check-generics.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
-- --------------------


[case testGenericMethodReturnType]
from typing import TypeVar, Generic
[case testGenericMethodReturnType]
T = TypeVar('T')
a: A[B]
b: B
Expand Down Expand Up @@ -3563,3 +3563,53 @@ def foo(x: T):
reveal_type(C) # N: Revealed type is "Overload(def [T, S] (x: builtins.int, y: S`-1) -> __main__.C[__main__.Int[S`-1]], def [T, S] (x: builtins.str, y: S`-1) -> __main__.C[__main__.Str[S`-1]])"
reveal_type(C(0, x)) # N: Revealed type is "__main__.C[__main__.Int[T`-1]]"
reveal_type(C("yes", x)) # N: Revealed type is "__main__.C[__main__.Str[T`-1]]"

[case testDeterminismFromJoinOrderingInSolver]
# Used to fail non-deterministically
# https://github.com/python/mypy/issues/19121
from __future__ import annotations
from typing import Generic, Iterable, Iterator, Self, TypeVar

_T1 = TypeVar("_T1")
_T2 = TypeVar("_T2")
_T3 = TypeVar("_T3")
_T_co = TypeVar("_T_co", covariant=True)

class Base(Iterable[_T1]):
def __iter__(self) -> Iterator[_T1]: ...
class A(Base[_T1]): ...
class B(Base[_T1]): ...
class C(Base[_T1]): ...
class D(Base[_T1]): ...
class E(Base[_T1]): ...

class zip2(Generic[_T_co]):
def __new__(
cls,
iter1: Iterable[_T1],
iter2: Iterable[_T2],
iter3: Iterable[_T3],
) -> zip2[tuple[_T1, _T2, _T3]]: ...
def __iter__(self) -> Self: ...
def __next__(self) -> _T_co: ...

def draw(
colors1: A[str] | B[str] | C[int] | D[int | str],
colors2: A[str] | B[str] | C[int] | D[int | str],
colors3: A[str] | B[str] | C[int] | D[int | str],
) -> None:
for c1, c2, c3 in zip2(colors1, colors2, colors3):
reveal_type(c1) # N: Revealed type is "Union[builtins.int, builtins.str]"
reveal_type(c2) # N: Revealed type is "Union[builtins.int, builtins.str]"
reveal_type(c3) # N: Revealed type is "Union[builtins.int, builtins.str]"

def draw_again(
colors1: B[str] | A[int | str] | C[str] | E[int] | D[int],
colors2: B[str] | A[int | str] | C[str] | E[int] | D[int],
colors3: B[str] | A[int | str] | C[str] | E[int] | D[int],
) -> None:
for c1, c2, c3 in zip2(colors1, colors2, colors3):
reveal_type(c1) # N: Revealed type is "Union[builtins.int, builtins.str]"
reveal_type(c2) # N: Revealed type is "Union[builtins.int, builtins.str]"
reveal_type(c3) # N: Revealed type is "Union[builtins.int, builtins.str]"
[builtins fixtures/tuple.pyi]