Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[mypyc] Enable free threading when compiling multiple modules #19541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JukkaL merged 15 commits into from
Jul 30, 2025
Merged

[mypyc] Enable free threading when compiling multiple modules #19541

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
62000a3
[mypyc] WIP free threading when compiling multiple modules
JukkaL Jul 23, 2025
5109f1f
WIP use multi-phase init for the shared library
JukkaL Jul 23, 2025
c7c681a
WIP run module top levels (but method table is still not applied)
JukkaL Jul 23, 2025
63d2f56
Actually populate module functions
JukkaL Jul 23, 2025
e557908
Update docstring
JukkaL Jul 23, 2025
ce60137
Don't generate redundant slots tables
JukkaL Jul 23, 2025
0225e34
Skip more steps if using multi-phase init and shared lib
JukkaL Jul 23, 2025
462314d
Fix non-multi-phase init shared lib
JukkaL Jul 23, 2025
2d1f1bf
Lint
JukkaL Jul 23, 2025
a3d23c9
Fix running on older Python versions
JukkaL Jul 30, 2025
70b0c7d
Simplify exec function
JukkaL Jul 30, 2025
ce4252a
Rename shim template file
JukkaL Jul 30, 2025
7c67217
Clean up
JukkaL Jul 30, 2025
d54c098
Minor tweak and formatting changes
JukkaL Jul 30, 2025
d14265b
Fix bad generated names
JukkaL Jul 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
WIP use multi-phase init for the shared library
  • Loading branch information
@JukkaL
JukkaL committed Jul 30, 2025
commit 5109f1fa00ca2b763060993e31fe23f2ea79e74b
48 changes: 33 additions & 15 deletions mypyc/codegen/emitmodule.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -784,28 +784,20 @@ def generate_shared_lib_init(self, emitter: Emitter) -> None:
assert self.group_name is not None

emitter.emit_line()

short_name = "g" + shared_lib_name(self.group_name).split(".")[-1] # TODO

emitter.emit_lines(
"PyMODINIT_FUNC PyInit_{}(void)".format(
shared_lib_name(self.group_name).split(".")[-1]
),
f"static int {short_name}_exec(PyObject *module_arg)",
"{",
(
'static PyModuleDef def = {{ PyModuleDef_HEAD_INIT, "{}", NULL, -1, NULL, NULL }};'.format(
shared_lib_name(self.group_name)
)
),
"int res;",
"PyObject *capsule;",
"PyObject *tmp;",
"static PyObject *module;",
"if (module) {",
"Py_INCREF(module);",
"return module;",
"}",
"module = PyModule_Create(&def);",
"if (!module) {",
"goto fail;",
"return 0;",
"}",
"module = module_arg;",
"",
)

Expand Down Expand Up @@ -861,7 +853,33 @@ def generate_shared_lib_init(self, emitter: Emitter) -> None:
"",
)

emitter.emit_lines("return module;", "fail:", "Py_XDECREF(module);", "return NULL;", "}")
emitter.emit_lines("return 0;", "fail:", "return -1;", "}")

emitter.emit_lines(
f"static PyModuleDef_Slot {short_name}_slots[] = {{",
f"{{Py_mod_exec, {short_name}_exec}},",
"{Py_mod_multiple_interpreters, Py_MOD_MULTIPLE_INTERPRETERS_NOT_SUPPORTED},",
"{Py_mod_gil, Py_MOD_GIL_NOT_USED},",
"{0, NULL},",
"};",
)

emitter.emit_lines(
f"static PyModuleDef {short_name}_module_def = {{",
"PyModuleDef_HEAD_INIT,",
f'.m_name = "{shared_lib_name(self.group_name)}",',
".m_doc = NULL,",
".m_size = 0,", # -1 originally
".m_methods = NULL,",
f".m_slots = {short_name}_slots,"
"};",
)

emitter.emit_lines(
f"PyMODINIT_FUNC PyInit_{short_name[1:]}(void) {{",
f"return PyModuleDef_Init(&{short_name}_module_def);",
"}",
)

def generate_globals_init(self, emitter: Emitter) -> None:
emitter.emit_lines(
Expand Down