Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Make the space in error comments optional #19546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wyattscarpenter wants to merge 22 commits into
base: master
Choose a base branch
from
Draft

Make the space in error comments optional #19546

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
eb75b05
Update update_data.py: make the space in error comments optional
wyattscarpenter Jul 30, 2025
8bb4ff6
Update README.md: docu for the spacedness thing
wyattscarpenter Jul 30, 2025
47f82d4
Update data.py: continue implementing optional spacedness
wyattscarpenter Jul 30, 2025
25b28c9
Update data.py: actually use re split
wyattscarpenter Jul 30, 2025
9705f73
Update data.py: use raw strings
wyattscarpenter Jul 30, 2025
59a14cb
Update README.md: remember that markdown also uses backslash escapes
wyattscarpenter Jul 30, 2025
ba6afdb
be more strict, but also more lenient, about error code comment format
wyattscarpenter Jul 31, 2025
467fdf1
message may include leading spaces
wyattscarpenter Jul 31, 2025
a56bebc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 31, 2025
a429c05
Handle zero-indent case in rewrite
wyattscarpenter Jul 31, 2025
796adda
fix broken tests, elaborate on test file format in the readme
wyattscarpenter Jul 31, 2025
33504bb
I hate black param wrapping on things that should be a single line
wyattscarpenter Jul 31, 2025
1bc3676
make tests
wyattscarpenter Jul 31, 2025
fd636a1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jul 31, 2025
55f3e68
typo
wyattscarpenter Jul 31, 2025
bcaef32
Merge branch 'master' into espace
wyattscarpenter Jan 10, 2026
4d72ec8
Apply suggestion from @wyattscarpenter
wyattscarpenter Feb 14, 2026
376c81e
Let any unescaped # character terminate a comment
wyattscarpenter Feb 24, 2026
df800b8
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 24, 2026
2f7b99b
let the column number also have arbitrary spacing
wyattscarpenter Feb 24, 2026
0ba4577
fix spaces paren grouping
wyattscarpenter Feb 24, 2026
8791ea0
accomodate urls again
wyattscarpenter Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update data.py: actually use re split
  • Loading branch information
@wyattscarpenter
wyattscarpenter authored Jul 30, 2025
commit 25b28c97f006e5972324404f043fd30591741ce5
2 changes: 1 addition & 1 deletion mypy/test/data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -533,7 +533,7 @@ def expand_errors(input: list[str], output: list[str], fnam: str) -> None:

for i in range(len(input)):
# The first in the split things isn't a comment
for possible_err_comment in input[i].split("(?!\\)#")[1:]:
for possible_err_comment in re.split("(?!\\)#", input[i])[1:]:
m = re.search(
r"^([ENW]):((?P<col>\d+):)? (?P<message>.*)$", possible_err_comment.strip()
)
Expand Down
Loading