Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix dict assignment to a wider context containing an incompatible typeddict of the same shape #19592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 2 commits into from
Aug 5, 2025
Merged

Fix dict assignment to a wider context containing an incompatible typeddict of the same shape #19592

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cfb130
Allow typeddict mismatches in non-exhaustive contexts
sterliakov Aug 4, 2025
57db925
Add negative test
sterliakov Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add negative test
  • Loading branch information
@sterliakov
sterliakov committed Aug 4, 2025
commit 57db925d62d9f1573b2dab1c967ef6ce05632d80
8 changes: 6 additions & 2 deletions test-data/unit/check-typeddict.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4297,9 +4297,13 @@ class TD(TypedDict):
x: int

x: Union[TD, dict[str, str]] = {"x": "foo"}
y: Union[TD, dict[str, int]] = {"x": "foo"} # E: Dict entry 0 has incompatible type "str": "str"; expected "str": "int"

def accepts_td(d: Union[TD, dict[str, str]]) -> None: ...
def ok(d: Union[TD, dict[str, str]]) -> None: ...
ok({"x": "foo"})

def bad(d: Union[TD, dict[str, int]]) -> None: ...
bad({"x": "foo"}) # E: Dict entry 0 has incompatible type "str": "str"; expected "str": "int"

accepts_td({"x": "foo"})
[builtins fixtures/dict.pyi]
[typing fixtures/typing-typeddict.pyi]
Loading