Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[mypyc] feat: specialize isinstance for tuple of primitive types #19949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JukkaL merged 14 commits into from
Sep 30, 2025
Merged

[mypyc] feat: specialize isinstance for tuple of primitive types #19949

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1975746
[mypyc] feat: specialize isinstance for tuple of primitive types
BobTheBuidler Sep 29, 2025
e23d1f1
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 29, 2025
95ee648
fix mypy errs
BobTheBuidler Sep 29, 2025
73f6297
fix: desc is None
BobTheBuidler Sep 29, 2025
7d5b66a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 29, 2025
ceda7cc
fix type errs
BobTheBuidler Sep 29, 2025
628294d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 29, 2025
0d51ead
add ir test
BobTheBuidler Sep 29, 2025
3ea6d17
Merge branch 'isinstance-tuple-of-primitives' of https://github.com/B…
BobTheBuidler Sep 29, 2025
8a3a1b2
Update specialize.py
BobTheBuidler Sep 29, 2025
355ceec
flip flop
BobTheBuidler Sep 29, 2025
c29d5cd
add a variety of run test cases
BobTheBuidler Sep 29, 2025
4e1596c
use cast
BobTheBuidler Sep 29, 2025
fa7f46b
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update specialize.py
  • Loading branch information
@BobTheBuidler
BobTheBuidler authored Sep 29, 2025
commit 8a3a1b285fe1a965f87d6666853f3d2a93fcb07b
2 changes: 1 addition & 1 deletion mypyc/irbuild/specialize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ def translate_isinstance(builder: IRBuilder, expr: CallExpr, callee: RefExpr) ->
is_last = i == len(descs) - 1
next_block = fail_block if is_last else BasicBlock()
builder.add_bool_branch(
builder.primitive_op(desc, [obj], expr.line), pass_block, next_block
builder.primitive_op(desc, [obj], expr.line), pass_block, next_block # type: ignore [arg-type]
Copy link
Copy Markdown
Collaborator

@JukkaL JukkaL Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you avoid the # type: ignore? If there is some typing issue, I'd prefer a cast since it's more specific and tells which argument is the problematic one.

Copy link
Copy Markdown
Contributor Author

@BobTheBuidler BobTheBuidler Sep 29, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. It was because descs has type list[PrimitiveDescription | None]

I'm assuming the if None in descs: return None can probably be considered as a TypeGuard of sorts by mypy but that's above my paygrade

)
if not is_last:
builder.activate_block(next_block)
Expand Down
Loading